Skip to content

refactor(@schematics/angular): remove unneeded getFileContent unit-test helper #30939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 15, 2025

Some schematic unit-tests were using the getFileContent helper utility that was no longer needed due to a Tree now containing a readText method. All usages of the helper and the helper itself have now been removed.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 15, 2025
…test helper

Some schematic unit-tests were using the `getFileContent` helper utility
that was no longer needed due to a `Tree` now containing a `readText` method.
All usages of the helper and the helper itself have now been removed.
@clydin clydin force-pushed the ng-schematics/helper-cleanup branch from 7d5e49d to 91d2107 Compare August 16, 2025 16:51
@clydin clydin marked this pull request as ready for review August 16, 2025 16:52
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 16, 2025
@clydin clydin requested a review from alan-agius4 August 16, 2025 20:22
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 18, 2025
@alan-agius4 alan-agius4 merged commit f8ad0f9 into angular:main Aug 18, 2025
32 checks passed
@clydin clydin deleted the ng-schematics/helper-cleanup branch August 18, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants